search

voxpupuli / puppet-epel

Setup/configure EPEL (extra repository for enterprise linux) with Puppet
Apache License 2.0
41 stars 95 forks source link

Module would be better if it used templates rather than sourced files #62

Closed alex-harvey-z3q closed 7 years ago

alex-harvey-z3q commented 7 years ago

This module is using the old files pattern to get files from a Puppet Master.

This is a problem because it breaks masterless Puppet, and introduces a dependency on an external system.

I propose to convert those files into ERB templates.

Is that OK?

rnelson0 commented 7 years ago

That sounds like a good idea! I don't have a preference, but I would consider EPP templates, too.

alex-harvey-z3q commented 7 years ago

It's just a matter of what to name the file right? There is nothing to interpolate. If so, .epp it is.

alex-harvey-z3q commented 7 years ago

On second thoughts, EPP breaks Puppet 3 AFAIK and that's not going to help me much because I am stuck on Puppet 3!

alex-harvey-z3q commented 7 years ago

@rnelson0 https://github.com/stahnma/puppet-module-epel/pull/63

alex-harvey-z3q commented 7 years ago

@rnelson0 It turns out that this old files source => ... pattern does not break masterless Puppet in general. I am not sure why I thought it did. I was looking at a strange issue where these files were installed as zero length files and I jumped to the wrong conclusion. I still think the patch I submitted is an improvement, aside from the misleading comment. So I sent another PR to fix the comment.

alex-harvey-z3q commented 7 years ago

I think this post here is correct, re masterless puppet and source => puppet:///modules/foo/bar https://serverfault.com/a/347912/374465

alex-harvey-z3q commented 7 years ago

Ok. The issue is that source => ... breaks a specific implementation of masterless puppet, namely masterless Puppet based on puppet apply --catalog catalog.json.

stahnma commented 7 years ago

I'd prefer to keep going with Puppet 4 and higher standards, as Puppet 3 is EOL.

alex-harvey-z3q commented 7 years ago

@stahnma I do plan to upgrade to Puppet 5 very soon, although I am not aware of any other large sites here in Sydney that have upgraded to Puppet 4 yet. Breaking Puppet 3 for people is just going to send more people off into Ansible land IMO.

stahnma commented 7 years ago

Is this fixed in 1.3.0? I think we switch the GPG key files to templates.

alex-harvey-z3q commented 7 years ago

Yes, my PR that changed the GPG key files to templates was merged.