voxpupuli / puppet-epel

Setup/configure EPEL (extra repository for enterprise linux) with Puppet
Apache License 2.0
41 stars 95 forks source link

GPG key isn't required to be present before the repositories #81

Closed bodgit closed 4 years ago

bodgit commented 5 years ago

The outcome from #72 and #73 means that the GPG key now isn't guaranteed to be imported before the Yum repositories are created which means if I install a package found in these repositories, I get the following errors:

GPG key retrieval failed: [Errno 14] curl#37 - "Couldn't open file /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7"

And then a bit further on, I finally see the GPG key get created:

Notice: /Stage[main]/Epel/File[/etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7]/ensure: defined content as '{md5}58fa8ae27c89f37b08429f04fd4a88cc'
Notice: /Stage[main]/Epel/Epel::Rpm_gpg_key[EPEL-7]/Exec[import-EPEL-7]/returns: executed successfully

I agree the original dependency chaining was a bit far reaching, but I think there needs to be something here to keep the resources within the context of this module in the correct order.

alexjfisher commented 4 years ago

Fixed in https://github.com/voxpupuli/puppet-epel/pull/86