search

voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

enable eb-family for all relevant firewalld-types #299

Closed sircubbi closed 1 year ago

sircubbi commented 4 years ago

see https://github.com/voxpupuli/puppet-firewalld/issues/298

Pull Request (PR) description

allow usage of family "eb" for creating bridge-rules.

This Pull Request (PR) fixes the following issues

Fixes #298

sircubbi commented 4 years ago

I would happy to help. However, I just searched for all occurences of "ipv6" and added "eb". Seems there are no tests for "ipv6" either, so I am unsure how to add proper tests for that.

igalic commented 4 years ago

🤦🏻‍♀️

vox-pupuli-tasks[bot] commented 4 years ago

Dear @sircubbi, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

sircubbi commented 4 years ago

About the failed CI test: I do not think that these is an issue caused by the suggested changes, as these tests fail within files not touched at all.

igalic commented 2 years ago

@sircubbi i had myself removed from Voxpupuli, when i was hired by Puppet and haven't been working with puppet since i was made redundant, so i don't qualify as reviewer.

maybe someone else from @voxpupuli contributors can?

sircubbi commented 1 year ago

Hi, any chance to rerun the checks and recheck this PR? I would really like to get this simple patch upstream before the next release hits. If those checks succeed I would rebase to a single a commit.

rwaffen commented 1 year ago

the ci is only commit based, so maybe do a git commit -m "retrigger checks" --allow-empty

sircubbi commented 1 year ago

the ci is only commit based, so maybe do a git commit -m "retrigger checks" --allow-empty

Did this, however that does not solve the issue since the CI wasn't triggered by the second commit either.

rwaffen commented 1 year ago

🤦 this repo has no ci. only a release workflow.

rwaffen commented 1 year ago

the fix for this will come with https://github.com/voxpupuli/puppet-firewalld/pull/347

sircubbi commented 1 year ago

I see, ok. Thanks so far. For the moment I just rebased this to a single commit.

jcpunk commented 1 year ago

I merged in the module sync to get the tests running. The ICMP tests don't work at this time and I'm super unclear why. But in theory you can get the other tests working...

sircubbi commented 1 year ago

I merged in the module sync to get the tests running. The ICMP tests don't work at this time and I'm super unclear why. But in theory you can get the other tests working...

I synced with your HEAD but already the static tests fail. Is it because of that outdated REFERENCE.md or because of the missing documentation (which is only logged as warn)?

jcpunk commented 1 year ago

https://voxpupuli.org/docs/how_to_run_tests/ has instructions for how to update REFERENCE.md.

If you're feeling up to adding the missing doc for those parameters that would also be welcome ;)

sircubbi commented 1 year ago

https://voxpupuli.org/docs/how_to_run_tests/ has instructions for how to update REFERENCE.md.

If you're feeling up to adding the missing doc for those parameters that would also be welcome ;)

Thanks for the pointer. At least my parts should be clean now.

I could look at those missing documentations, but I feel it should be a separate PR?

jcpunk commented 1 year ago

I could look at those missing documentations, but I feel it should be a separate PR?

That would be great!