search

voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

modulesync 5.3.0; Drop Puppet 5 support #303

Closed bastelfreak closed 1 year ago

bastelfreak commented 4 years ago

modulesync 4.0.0

ekohl commented 4 years ago

That's using the simp helpers so not a trivial conversion. Also not sure if firewalld actually works in containers.

bastelfreak commented 2 years ago

I disabled acceptance tests for now. this allows us to merge the PR and at least enable unit testing

trevor-vaughan commented 2 years ago

@ekohl firewalld has the ability to run in containers but the containers have to be started privileged with CAP_NET_ADMIN so that the underlying tools can access the napespaced firewall. It's completely hit and miss.

iptables had the ability to work this way but I haven't checked nftables yet. Would recommend keeping the acceptance tests targeting VMs until it can all be confirmed.

jcpunk commented 1 year ago

There's been enough drift that it might be worth redoing this PR?

bastelfreak commented 1 year ago

as stated on the mailinglist: I got the impression that the module is abandoned and I've no plans to work further on it. If someone want's to keep using it I suggest someone tries a new modulesync.

jcpunk commented 1 year ago

Somehow my subscription to that list got suspended...

Trying in https://github.com/voxpupuli/puppet-firewalld/pull/347