Fixes firewalld_custom_service where only protocols are defined

voxpupuli / puppet-firewalld

Puppet module for managing firewalld

Apache License 2.0

40 stars 77 forks source link

Fixes firewalld_custom_service where only protocols are defined #307

Closed nmaludy closed 2 years ago

nmaludy commented 3 years ago

Pull Request (PR) description

Previously if you wanted to define a custom service that only allows protocols it would error when adding protocols to the service. This was caused by the Puppet code omitting the ports array and the provider assuming that the ports array was specified.

I simply added a check to see if ports array was :unset and if it's :unset just skip finding protocols from that array.

This Pull Request (PR) fixes the following issues

Fixes #306

jovandeginste commented 2 years ago

ping ?

alexjfisher commented 2 years ago

@nmaludy Thanks! (and sorry for the delay).