search

voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

[Feature] Validate zone sources arguments (only support IP addresses) #325

Open jcpunk opened 2 years ago

jcpunk commented 2 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

  firewalld_zone { 'restricted':
    ensure           => present,
    target           => '%%REJECT%%',
    purge_rich_rules => true,
    purge_services   => true,
    purge_ports      => true,
    sources          => ['example.host.com', 'other.host.com'],
  }

What are you seeing

Firewalld rejects the hostname based source

What behaviour did you expect instead

The module would restrict the sources to Array[Stdlib::IP::Address]

Output log

Any additional information you'd like to impart