search

voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

Release of 4.5.0 #326

Closed trevor-vaughan closed 2 years ago

trevor-vaughan commented 2 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

bastelfreak commented 2 years ago

please rebase this after https://github.com/voxpupuli/puppet-firewalld/pull/303 got merged and make it a 5.0.0 release

trevor-vaughan commented 2 years ago

@bastelfreak Looks like #303 is stuck in limbo. Can this be released as 4.4.1 and then 5.0.0 released after #303 is resolved?

trevor-vaughan commented 2 years ago

@bastelfreak #303 is still in limbo. Can we get this out without it?

bastelfreak commented 2 years ago

I noticed that we cannot release this easily, the github action is missing. I rebased this one and updated it from a 4.4.1 to a 4.5.0 release because it contains an enhancement change. we need to at least cherry-pick the release action from the modulesync PR (and probably the Gemfile)