voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

Add support for icmp-block-inversion #330

Closed jcpunk closed 1 year ago

jcpunk commented 2 years ago

Pull Request (PR) description

Attempt to add support for icmp-block-inversion. Folks who've manually set this will need to be aware since it becomes managed with this change.

This Pull Request (PR) fixes the following issues

Fixes #270

jcpunk commented 2 years ago

I'm not sure how to do that....

bastelfreak commented 1 year ago

I think the unit tests are fine, but we should keep this open until we've a few breaking changes that we can release in one go.