voxpupuli / puppet-firewalld

Puppet module for managing firewalld
Apache License 2.0
40 stars 77 forks source link

List more autorequired resources in firewalld_rich_rule doc (and readme) #370

Open qha opened 6 months ago

qha commented 6 months ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Visual inspection of puppet-firewalld/lib/puppet/type/firewalld_rich_rule.rb, puppet-firewalld/README.md and published readme/reference on https://forge.puppet.com/modules/puppet/firewalld

What are you seeing

Helpful statements that claim "firewalld_rich_rules will autorequire the firewalld_zone specified in the zone parameter or the firewalld_policy specified in the policy parameter so there is no need to add dependencies for this" along with even more helpful code that autorequires ipset and service resources in addition to the already mentioned zone and policy resources.

What behaviour did you expect instead

Documentation and code in sync.

Output log

-

Any additional information you'd like to impart

-