Optimize - Githubissues

voxpupuli / puppet-ghostbuster

👻 Dead code detector for Puppet

Apache License 2.0

93 stars 27 forks source link

Optimize #83

Closed h0tw1r3 closed 9 months ago

h0tw1r3 commented 9 months ago

read file by line until match
only read files once per check
prefer include over match
support hiera datadir

Replacing readlines.grep also happens to fix #63. Tried to create a test, but I was unable to reproduce outside of a production environment.

bastelfreak commented 9 months ago

@h0tw1r3 thanks a lot for the PR! Code looks really good. One nitpick: I'm not sure how we can give those changes a proper PR title. Do you have an idea? Otherwise could you split those commits up into 4 PRs maybe?

h0tw1r3 commented 9 months ago

superseded by #84 #85 #86 #87