voxpupuli / puppet-gitlab

Puppet module to manage Gitlab (Omnibus)
https://forge.puppet.com/puppet/gitlab/
BSD 3-Clause "New" or "Revised" License
74 stars 164 forks source link

Fix gitlab-ctl reconfigure LD_LIBRARY_PATH warning #364

Closed lnemsick-simp closed 4 years ago

lnemsick-simp commented 4 years ago

Pull Request (PR) description

This patch ensures LD_LIBRARY_PATH is unset in the gitlab-ctl configure exec resource.

This Pull Request (PR) fixes the following issues

Fixes the LD_LIBRARY_PATH warning emitted at the end of gitlab-ctl reconfigure.

As shown in https://travis-ci.org/github/voxpupuli/puppet-gitlab/jobs/739916738 on lines 2089-2090, gitlab-ctl reconfigure emits a warning when LD_LIBRARY_PATH is set. It emits this warning even if that environment variable is empty. Since LD_LIBRARY_PATH is always set by the Puppet wrapper script used in the puppet CLI, the exec that runs gitlab-ctl configure must unset this variable to avoid the warning message.