voxpupuli / puppet-gitlab

Puppet module to manage Gitlab (Omnibus)
https://forge.puppet.com/puppet/gitlab/
BSD 3-Clause "New" or "Revised" License
74 stars 164 forks source link

Gitab.rb sidekiq queue_groups array quoted. #406

Open ccombs-trustamerica opened 1 year ago

ccombs-trustamerica commented 1 year ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

sidekiq => {
      queue_groups    => '[\\'*\\'] * 4',
    },

OR

sidekiq => {
      queue_groups    => "['*'] * 4",
    },

What are you seeing

Both produce the same result: gitlab.rb: sidekiq['queue_groups'] = "['*'] * 4"

What behaviour did you expect instead

gitlab.rb: sidekiq['queue_groups'] = ['*'] * 4

Output log

Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns:
Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: ================================================================================ Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: Error executing action create on resource 'template[/opt/gitlab/sv/sidekiq/run]' Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: ================================================================================ Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns:
Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: Chef::Mixin::Template::TemplateError Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: ------------------------------------ Notice: /Stage[main]/Gitlab::Service/Exec[gitlab_reconfigure]/returns: undefined method `each' for "[''] 4":String

Any additional information you'd like to impart

If I try:

sidekiq                 => {
  queue_groups    => ['[\\'*\\'] * 4'],
},

Gitlab.rb: sidekiq['queue_groups'] = ["['*'] * 4"]

The reconfigure doesn't error, but I also don't get 4 sideqik processes.

https://docs.gitlab.com/ee/administration/sidekiq/extra_sidekiq_processes.html