voxpupuli / puppet-gitlab

Puppet module to manage Gitlab (Omnibus)
https://forge.puppet.com/puppet/gitlab/
BSD 3-Clause "New" or "Revised" License
74 stars 164 forks source link

Is the store_git_keys_in_db parameter still required or functionality valid? #420

Open jjarokergc opened 11 months ago

jjarokergc commented 11 months ago

The store_git_keys_in_db parameter appears to be inconsistent with gitlab version 14+ as described in the setup instructions here: https://docs.gitlab.com/ee/administration/operations/fast_ssh_key_lookup.html

If this parameter is set to true, a file is created in /opt/gitlab-shell/authorized_keys that tries to call a non-existent command. Gitlab (at least from version 14) already has commands located in /opt/gitlab/embedded/service/gitlab-shell/bin for the fast lookup of keys.

Setting the parameter to true also creates a dependency failure because host_config.pp attempts to manage File['/opt/gitlab-shell'] before actually creating the user or group git.