search

voxpupuli / puppet-gitlab

Puppet module to manage Gitlab (Omnibus)
https://forge.puppet.com/puppet/gitlab/
BSD 3-Clause "New" or "Revised" License
74 stars 164 forks source link

Update to support Praefect #422

Closed danielgriggs closed 5 months ago

danielgriggs commented 10 months ago

Update to support Praefect configuration

Stolen from https://github.com/voxpupuli/puppet-gitlab/pull/372

Pull Request (PR) description

This PR takes the work done by @rudexi and provides a way to configure Praefect.

This Pull Request (PR) fixes the following issues

Fixes partially https://github.com/voxpupuli/puppet-gitlab/issues/366

danielgriggs commented 10 months ago

Running the tests locally only show error with things I didn't change, so I guess I didn't make anything worse :P

smortex commented 10 months ago

REFERENCE.md is outdated

:thinking: Did you adjusted REFERENCE.md by hand? Update it with:

$ bundle exec rake strings:generate:reference

Then amend and push your commit, and CI should continue.

danielgriggs commented 10 months ago

Ah, my work laptop is pretty locked down, so I can only use exactly ruby 2.7, only 2.5.9 or 3.0.4. So bundle is either too out of date or URI is too new and doesn't support the escape() function. Also not being a Ruby developer I can't seem to generate an environment that matches the required environment for the tests.