search

voxpupuli / puppet-gitlab

Puppet module to manage Gitlab (Omnibus)
https://forge.puppet.com/puppet/gitlab/
BSD 3-Clause "New" or "Revised" License
74 stars 164 forks source link

feature/package_hold #440

Open NeatNerdPrime opened 2 weeks ago

NeatNerdPrime commented 2 weeks ago

Pull Request (PR) description

Introducing the package_holdparameter

The package_hold parameter allows you to hold the package version in the APT package manager. This is useful when you intend to update the host with 'apt upgrade' (or the bolt task apt action=upgrade from puppetlabs-apt) and keep your gitlab instance at the intended version. This prevents unintended upgrading gitlab and perhaps skipping important upgrade path steps.

NeatNerdPrime commented 2 days ago

@bastelfreak Thanks for considering my PR.

bastelfreak commented 2 days ago

Thanks for the PR! Can you please add a unit test for the change?

NeatNerdPrime commented 2 days ago

And Voila! Got done in a bit by the style, but it includes the test describes it quite nicely.

Thanks again for considering my PR :-)