Add parameters to `apt::source` to avoid requiring an internet connection

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab

Apache License 2.0

14 stars 52 forks source link

Add parameters to `apt::source` to avoid requiring an internet connection #100

Open micedre opened 3 years ago

micedre commented 3 years ago

Pull Request (PR) description

Adds some parameters to apt::source on debian family when managing repo.

This Pull Request (PR) fixes the following issues

Fixes #99

micedre commented 3 years ago

I added some tests by copying some existing, but I didn't manage to execute those (following what I see in .github/CONTRIBUTING.md). Do you have some pointer to execute those tests ?

vox-pupuli-tasks[bot] commented 3 years ago

Dear @micedre, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

micedre commented 3 years ago

I don't really understand what fails in this CI, it does not seem to come from my modification (but maybe), can you give some pointer on how to fix it? Thanks