Fix Github CI builds and modulesync

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab

Apache License 2.0

14 stars 53 forks source link

Fix Github CI builds and modulesync #104

Closed alexjfisher closed 3 years ago

alexjfisher commented 3 years ago

This PR is a continuation of https://github.com/voxpupuli/puppet-gitlab_ci_runner/pull/93 (which I accidentally got into a closed state I couldn't reopen).

alexjfisher commented 3 years ago

@trevor-vaughan Hi! Any chance you could spare some beaker docker expertise?

Our github workflow has a 'gitlab' service started, but the beaker container doesn't seen to have any network connectivity with it. (Also see this thread)

Feel free to push any commits BTW ;)

baurmatt commented 3 years ago

I tried to debug this a little bit further. Some things I've learned:

Github Actions creates a dedicated bridge network in which it runs services
Beaker containers are started in another bridge network, making it impossible to reach the Gitlab service running in the dedicated bridge network
Github Actions seems to have no way to change the dedicated network
We might be able to switch the Beaker container to the Github Actions network by leveraging the dockeropts config option. But I don't understand the syntax.
Using the "voxpupuli/puppet-vault_lookup" solution (creating a dedicated beaker nodeset) seems to be not an option because we would need to do it for each supported OS.

ekohl commented 3 years ago

Let's see if I broke it again with my latest change. Feel free to drop that commit if it doesn't.

ekohl commented 3 years ago

We shouldn't forget to create issues that we've dropped Amazon Linux and EL6 for the changelog.

alexjfisher commented 3 years ago

I think the next release will have a substantial release summary. I'm hoping to get PR together based on https://github.com/syseleven/puppet-gitlab_ci_runner/tree/clean-move-to-concat-deferred At the moment, the config file is only written when registering a runner, and any subsequent config changes you make have no effect. There are also plenty of more exotic configurations you can't make whilst registering.

alexjfisher commented 3 years ago

For completeness (and mainly because I pinged Trevor and don't want to waste his time!), in https://github.com/voxpupuli/puppet-gitlab_ci_runner/pull/105 I managed to get the docker networking working in the way we originally wanted. Might revisit this at a later date.

alexjfisher commented 3 years ago

We shouldn't forget to create issues that we've dropped Amazon Linux and EL6 for the changelog.

Done via https://github.com/voxpupuli/puppet-gitlab_ci_runner/issues/118