Add support for registration by leveraging a "Deferred" function

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab

Apache License 2.0

14 stars 52 forks source link

Add support for registration by leveraging a "Deferred" function #107

Closed baurmatt closed 2 years ago

baurmatt commented 2 years ago

Pull Request (PR) description

This reintroduces the possiblty to register a Gitlab Runner by Puppet without the need of a manual step. This is done by using a "Deferred" function which does the registration and returns the authentication token for the configuration.

As Deferred is a >= Puppet 6 functionality this also drops support for old Puppet versions.

This is the follow-up PR for #75.

This Pull Request (PR) fixes the following issues

alexjfisher commented 2 years ago

I noticed previous versions of this patch had an unregister_from_file function. What were your thoughts behind removing this? I guess it'd be the only reason why runner might need an ensure parameter, so maybe the bolt task is good enough?