search

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab
Apache License 2.0
14 stars 52 forks source link

Update readme with required Puppet and concat versions #153

Closed CommanderTso closed 1 year ago

CommanderTso commented 1 year ago

Hey folks,

I ended up spinning my wheels for a bit trying to figure out why the module wouldn't work for us - it turns out you need to have puppetlabs-concat installed at 6.3 or greater in order for it to handle Deferred functions. This PR adds a section to the readme noting that you need at least Puppet 6 and at least concat 6.3. Happy to modify as needed. Thanks.

CommanderTso commented 1 year ago

The check failure here seems to be related to the setup, not the commit.

smortex commented 1 year ago

CI failure is related to the change. That being said, the dependencies are correct in metadata.json and it's the place we want them to be up-to-date. I am not sure we will always think to duplicate the dependencies requirements update in the README when they are changed in the metadata file.

CommanderTso commented 1 year ago

My apologies! I totally misread the error. Fixed in the new commit.

Understood re: the metadata. I hadn't realized that because any warnings we might see in our environment are buried - going to look into that. Please feel free to merge or close this as you folks like.