voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab

Apache License 2.0

14 stars 52 forks source link

Add Puppet 8 support #173

Closed bastelfreak closed 7 months ago

smortex commented 1 year ago

I saw similar issues for the modules of @opus-codium, and a ModuleSync update helped.

170 was about it but I got stuck by ENTREPRISE LINUX issues. A quick fix of dropping CentOS 7 is I guess not acceptable :upside_down_face:

bastelfreak commented 1 year ago

I think CentOS 7 is so old and we've the option to support EL8 and EL9, I think it's fine to drop CentOS 7 if it helps moving forward.

smortex commented 9 months ago

Comparing Puppet 7 and 8, we have this error with Puppet 8:

2023-09-26T02:29:11.2843101Z [00;00m[00;33m Error: /Stage[main]/Gitlab_ci_runner::Config/Concat[/etc/gitlab-runner/config.toml]/Concat_file[/etc/gitlab-runner/config.toml]: Failed to generate additional resources using 'eval_generate': no implicit conversion of Puppet::Pops::Evaluator::DeferredValue into String

This led me to: https://github.com/puppetlabs/puppetlabs-concat/pull/789

smortex commented 7 months ago

Now that https://github.com/puppetlabs/puppetlabs-concat/pull/789 is released in puppetlabs-concat 9.0.1, this will maybe pass with Puppet 8? Close and re-open to give it another try.