search

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab
Apache License 2.0
14 stars 52 forks source link

Use apt keyring on Debian #189

Closed jonhattan closed 2 weeks ago

jonhattan commented 2 months ago

Pull Request (PR) description

Indirectly use apt::keyring instead of apt::key (deprecated) by passing name istead of id in apt::source's key subkey.

This is almost the same fix as #188 but that other is wrong because the gpg key filename must use .asc extension since gitlab provided one is ascii armored.

traylenator commented 2 months ago

Requires #191

yakatz commented 1 month ago

Now that #191 is merged, does this need to be rebased before the tests can pass or should we be able to just trigger them again?

TheMeier commented 1 month ago

Please rebase, I think there is also some tests you need to adapt. See https://voxpupuli.org/docs/how_to_run_tests/ fro running the tests locally

yakatz commented 1 month ago

@jonhattan Can you rebase?

jonhattan commented 1 month ago

Rebased. I don't know how to fix the test. IMO $repo_keyserver is no longer needed. Any guidance?

yakatz commented 1 month ago

Something like

is_expected.to contain_apt__source('apt_gitlabci').with_key('name' => 'gitlab_ci_runner.asc', 'source' => 'https://packages.gitlab.com/gpg.key')

should do it.

TheMeier commented 1 month ago

Please remove the refrence to #188 from the first comment, that is a pull request not an issue

jonhattan commented 1 month ago

I think it is ready now