search

voxpupuli / puppet-gitlab_ci_runner

Module to mange gitlab CI runners. Extracted from https://github.com/voxpupuli/puppet-gitlab
Apache License 2.0
14 stars 52 forks source link

Adding the option to disable the '_' to '-' replacement in configuration #97

Closed ranzbak closed 3 years ago

ranzbak commented 3 years ago

This breaks keys in the runner config, which has command line options that contain a '_'.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ranzbak commented 3 years ago

The tests are indeed missing, I'll get back to you when they are created.

bastelfreak commented 3 years ago

mhm I'm afraid we somehow need to get https://github.com/voxpupuli/puppet-gitlab_ci_runner/pull/93 fixed before we can merge #97 :(

vox-pupuli-tasks[bot] commented 3 years ago

Dear @ranzbak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks