voxpupuli / puppet-grafana

Puppet module to manage Grafana
Apache License 2.0
15 stars 106 forks source link

Create grafana config directory #339

Open m0dular opened 11 months ago

m0dular commented 11 months ago

Prior to this commit, attempting to created a provisioned datasource or dashboard after installing from an archive source would fail with the following:

Could not set 'file' on ensure: No such file or directory - A directory component in /etc/grafana/provisioning/datasources/ does not exist or is a dangling symbolic link

This commit ensure that archive installations create the directory with a default of /etc/grafana

m0dular commented 11 months ago

So this was part of work to add versions to archive installations in operational dashboards, but I'm realizing that it doesn't work and probably hasn't been for a while, at least on some platforms.

On SLES 12 and 15 it claims to start the service but doesn't, and I assume it has something to do with how it's defined here. We'd also have to do something like we do with the systemd config file in ops dashboards so that we know the server is fully started. But since it's manually starting the service with the binary option and not using systemd that would be more work.

Should we just drop archive support in this module and ops dashboards? It looks like there's a package available for all major platforms, and using a repo or package is so much easier.

sebastianrakel commented 3 months ago

is this still necessary? we merged PR #362 which creates the needed folder