voxpupuli / puppet-graylog_api

Puppet module for managing Graylog configuration via REST API
Apache License 2.0
7 stars 3 forks source link

Corrected id values during POST and PUT requests #3

Closed np-at closed 2 years ago

np-at commented 3 years ago

During create operations, an id value was being provided (the id field was erroneously being assigned from the name of the resource). This was resulting in an invalid reference server side. => Fix was a little hacky. I forced the ID param to nil during create operations before sending (didn't want to accidentally break something else that was depending on the name/ID fallback)

During update operations the difference between the url path ID parameter and the body json ID was causing an error in the server API (I didn't examine the raw request so it may be a typing error from puppet where the ID value was being specified as null or "" in the request rather than omitted). => Fix was to explicitly specify the ID param in the body content to match the url path param. I'm a novice at Ruby so feel free to suggest improvements.