Update to use pdk 2.x without fails

[cocker-cc]

Make "pdk validate" succeed on Module "puppet-icinga2"

Expected Behavior

pdk validate should not fail.

Current Behavior

pdk validate fails…

$ pdk validate; echo $?
[…]
1

… on many Ruby-Files:

lib/puppet/functions/icinga2/icinga2_attributes.rb                          
lib/puppet/functions/icinga2/icinga2_ticket_id.rb                           
lib/puppet/parser/functions/icinga2_attributes.rb                           
lib/puppet/parser/functions/icinga2_ticket_id.rb                            
lib/puppet_x/icinga2/pbkdf2.rb                                              
lib/puppet_x/icinga2/utils.rb                                               
spec/acceptance/class_spec.rb                                               
spec/classes/api_spec.rb                                                    
spec/classes/checker_spec.rb                                                
spec/classes/command_spec.rb                                                
spec/classes/compatlog_spec.rb                                              
spec/classes/debuglog_spec.rb                                               
spec/classes/elasticsearch_spec.rb                                          
spec/classes/gelf_spec.rb                                                   
spec/classes/graphite_spec.rb                                               
spec/classes/icinga2_spec.rb                                                
spec/classes/icingadb_spec.rb                                               
spec/classes/idomysql_spec.rb                                               
spec/classes/idopgsql_spec.rb                                               
spec/classes/influxdb_spec.rb                                               
spec/classes/livestatus_spec.rb                                             
spec/classes/mainlog_spec.rb                                                
spec/classes/notification_spec.rb                                           
spec/classes/opentsdb_spec.rb                                               
spec/classes/perfdata_spec.rb                                               
spec/classes/pki_ca_spec.rb                                                 
spec/classes/statusdata_spec.rb                                             
spec/classes/syslog_spec.rb                                                 
spec/defines/feature_spec.rb                                                
spec/defines/fragment_spec.rb                                               
spec/defines/objects_spec.rb                                                
spec/functions/attributes_spec.rb                                           
spec/functions/icinga2_icinga2_attributes_spec.rb                           
spec/functions/icinga2_icinga2_ticket_id_spec.rb                            
spec/spec_helper_acceptance.rb                                              
spec/type_aliases/fingerprint_spec.rb                                       
spec/type_aliases/interval_spec.rb                                          
spec/type_aliases/logseverity.rb                                            
spec/unit/facter/util/fact_icinga2_puppet_hostcert_spec.rb                  
spec/unit/facter/util/fact_icinga2_puppet_hostprivkey_spec.rb               
spec/unit/facter/util/fact_icinga2_puppet_localcacert_spec.rb

Possible Solutions

• adapt .rubocop.yml
• improve Ruby-Files
• put Ruby-File on Ignore-List

Your Environment

$ pdk --version
2.1.1

$ pdk bundle exec rubocop --version
pdk (INFO): Using Ruby 2.6.7
pdk (INFO): Using Puppet 7.9.0
0.49.1

[lbetz]

ok, I'm still using pdk 1.18 at the moment.