search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Mysql java connector proxy support #235

Closed mattpgh closed 3 years ago

mattpgh commented 6 years ago

With the recent addition of proxy support, I found it was missing proxy support for the mysql-connector. It also was missing puppet-archive support.

bastelfreak commented 6 years ago

Hi @mattpgh, thanks for the PR. You touched a lot of files that aren't related to the change, please don't do this. They are templated and come from our modulesync_config. Can you please remove them from the branch and rebase?

mattpgh commented 6 years ago

Sorry about that, just used the pdk as I normally would without thinking about it.

Is this better now?

bastelfreak commented 6 years ago

Thanks. Can you take a look at the failing travis jobs? The complain about hard tabs / wrong indentation

vox-pupuli-tasks[bot] commented 4 years ago

Dear @mattpgh, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @mattpgh, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

ekohl commented 3 years ago

The current version does appear to pass proxy params and uses the archive module. Please open a new PR if you're still missing anything.