voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Jira 7.12 needs relaxedPathChars & relaxedQueryChars #269

Closed nambrosch closed 4 years ago

nambrosch commented 5 years ago

Jira 7.12 runs on tomcat 8.5 and needs additional connector parameters -

https://confluence.atlassian.com/jirakb/changing-server-xml-to-handle-requests-with-special-characters-958453799.html

Here's the new default connector -

<Connector
  port="8080"
  relaxedPathChars="[]|"
  relaxedQueryChars="[]|{}^&#x5c;&#x60;&quot;&lt;&gt;"
  maxThreads="150"
  minSpareThreads="25"
  connectionTimeout="20000"
  enableLookups="false"
  maxHttpHeaderSize="8192"
  protocol="HTTP/1.1"
  useBodyEncodingForURI="true"
  redirectPort="8443"
  acceptCount="100"
  disableUploadTimeout="true"
  bindOnInit="false"
/>

Please provide a way to add relaxedPathChars and relaxedQueryChars. Thanks!

nambrosch commented 5 years ago

something like this should work @ https://github.com/voxpupuli/puppet-jira/blob/master/templates/server.xml.erb#L77

<% if @version >= 7.12 -%>
                   relaxedPathChars="[]|"
                   relaxedQueryChars="[]|{}^&#x5c;&#x60;&quot;&lt;&gt;"
<% end -%>
alexvanvucht commented 5 years ago

As a workaround you can append these to the proxy parameter, eg: proxy => { 'scheme' => 'https', 'proxyName' => $facts['hostname'], 'proxyPort'=>'443', 'relaxedPathChars'=>'[]|', 'relaxedQueryChars'=>'[]|{}^\`"<>' },

nambrosch commented 5 years ago

this workaround works, thank you. i'll keep an eye out for the next update.

proxy          => {
  proxyName         => 'mysite.com',
  proxyPort         => '443',
  relaxedPathChars  => '[]|',
  relaxedQueryChars => '[]|{}^&#x5c;&#x60;&quot;&lt;&gt;',
  scheme            => 'https',
},
mcruzmetrostar commented 5 years ago

BUMP for this issue, this change is also needed on JIRA 7.13.0

bastelfreak commented 5 years ago

Hi @nambrosch or @mcruzmetrostar, could one of you provide a PR for this?

mojibake-umd commented 4 years ago

This was actually added in f6bd5405ec50ae5e444a38a869b7b647d9764ff9 so this can get closed?

nambrosch commented 4 years ago

@mojibake-umd yes, i've been using module version 4.0.0 since june 20th and it works fine.