search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Issue269 #279

Closed tleveille closed 4 years ago

tleveille commented 5 years ago

Pull Request (PR) description

Fix for https://confluence.atlassian.com/jirakb/changing-server-xml-to-handle-requests-with-special-characters-958453799.html by adding relaxedPathChars and relaxedQueryChars directives to server.xml on jira version starting from 7.12

This Pull Request (PR) fixes the following issues

Fixes #269

bastelfreak commented 5 years ago

Hi @tleveille, thanks for the PR! Can you have a look at the used email address in the commits? It isn't associated with your github account. Also please have a look at the failed travis jobs.

tleveille commented 5 years ago

Hit @bastelfreak ,

That email address is my corporate one. I just added it to my github profile.

The failed travis jobs are most probably unrelated to that particular PR as I only edited the server.xml.erb template. Logs mention a dependency cycle and it seems to affect master as per the travis-build I just ran on your latest commit on the master branch: https://travis-ci.org/tleveille/puppet-jira/builds/486066211

I guess a dependent module has been udpated since your last build. That issue should be addressed separately.

Regards, Thomas

DaveTCode commented 5 years ago

Checking in to say that I was about to submit a PR for the same exact issue and would love to see this merged and put into a new release.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @tleveille, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @tleveille, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

dhoppe commented 4 years ago

This has been solved via #288