search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Added relaxedPath xml attributes as per jira apache tomcat upgrade file #280

Closed domgoodwin closed 5 years ago

domgoodwin commented 5 years ago

Notes: https://confluence.atlassian.com/jirasoftware/jira-software-7-13-x-upgrade-notes-957135908.html

Pull Request (PR) description

Add relaxedPath attributes into tomcat config to support Jira 7.13+

vrmerlin commented 5 years ago

I hope this can be added soon -- it's preventing me from doing any upgrades (including the new 8.0 that just came out).

bastelfreak commented 5 years ago

@vrmerlin the tests are failing on this one, we cannot merge it. But you can always checkout the branch, update it, and provide it as another PR.

vrmerlin commented 5 years ago

@bastelfreak Yes, I understand. I wasn't the original person who made the pull request, so i didn't want to step on Dom's toes if he was working on it.

@domgoodwin are you working on a fix to the PR?

domgoodwin commented 5 years ago

Honestly I wasn't sure on the issues raised from the Travis CI build. @vrmerlin feel free to update 👍

vrmerlin commented 5 years ago

No idea what i'm doing either, but I'll play around with it.

vrmerlin commented 5 years ago

@domgoodwin the failure I'm seeing is this:

is_expected.to contain_file('/opt/jira/atlassian-jira-6.3.4a-standalone/conf/server.xml').
   with_content(%r{<Connector port=\"9229\"\s+address=\"127\.0\.0\.1\"\s+maxThreads=}m)

I think all you need to do is move your two "relaxedPathChars" entries down further in the list, past the maxThreads, so that this rule still passes. Can you make that change? It might go a lot faster that way.

vrmerlin commented 5 years ago

It passed all the tests now!! :-) Thanks for the second fix, @domgoodwin .

@bastelfreak Can this be approved and merged now? I'm giving a demo to another team in a few days, on how easy a JIRA upgrade is...

domgoodwin commented 5 years ago

Thanks for the assistance spotting that issue @vrmerlin 🥇

vrmerlin commented 5 years ago

@bastelfreak FYI, I pulled down @domgoodwin 's branch, and used it to do an upgrade to JIRA 8.0, and it worked great!

bastelfreak commented 5 years ago

thanks everybody!