search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

WIP: Support Oracle Service Names as well as SIDs #284

Closed negast closed 3 years ago

negast commented 5 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

negast commented 5 years ago

I added an additional param called oracle_sid which is set to true by default. If set to true the old syntax is used else the service syntax is used. I added this param to the readme documentation.

negast commented 5 years ago

I don't get why the build is failing did I do something wrong here?

alexjfisher commented 5 years ago

@negast Beaker tests can be a bit flakey. I restarted your build and it passed.

bastelfreak commented 5 years ago

@negast can you take a look at the used email address in the commits? It isn't associated with your github account.

negast commented 5 years ago

@negast can you take a look at the used email address in the commits? It isn't associated with your github account.

I'm sorry where can I view this? I also changed my mail address recently for github.

bastelfreak commented 5 years ago

The email address is correct now. You can see your avatar next to the commit, which means that you use a email address that is linked to a github account. Otherwise you can see the address with git show $commitid

oranenj commented 3 years ago

I redid this in #365 , including credit to @negast. I'll close this PR