search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Jira Service Desk doesn't start with JasperListener / need relaxedPath with correct version comp #288

Closed thonixx closed 5 years ago

thonixx commented 5 years ago

Pull Request (PR) description

Pull request of #260 (issue #259) wanted to prevent JasperListener to be activated for Service Desk. Version comp condition can't be fulfilled as Jira and Service Desk have different version numbers.

Therefore JasperListener gets added to the server.xml anyway with Service Desk. To get Service Desk working we need to adapt the condition to not match when we run Jira Service Desk.

Also relaxedPath options only needed from Jira version >v7.12.1 and Service Desk

(According to https://confluence.atlassian.com/jirakb/changing-server-xml-to-handle-requests-with-special-characters-958453799.html)

We need to have relaxedPathChars and relaxedQueryChars set according to the FAQ page of Atlassian with Jira version greater than 7.12.1 and apparently Service Desk.

This Pull Request (PR) fixes the following issues

Issue does not exist (yet), relates to issue #259 which doesn't work. Also relaxedPath should only be configured with the correct versions and for Service Desk.

bastelfreak commented 5 years ago

thanks for the fix @thonixx !

zogot commented 5 years ago

Any chance to get this released? It's been a few months since this got merged, but it would be valuable for those that are upgrading to version 8 of jira, of which the arguments are required.

bastelfreak commented 5 years ago

hey @zogot, a new release depends on https://github.com/voxpupuli/puppet-jira/pull/298 and I currently don't have the time to look into this. Please let us know if you would like to help out. If so, you can have a look at the failed travis jobs and investigate why postgres isn't working.