Fix systemd service file mode

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module

https://forge.puppet.com/puppet/jira

Apache License 2.0

62 stars 144 forks source link

Fix systemd service file mode #290

Closed vanElden closed 4 years ago

vanElden commented 5 years ago

Pull Request (PR) description

On systems with systemd the following warning is logged at every start of JIRA: "Configuration file /lib/systemd/system/jira.service is marked executable. Please remove executable permission bits. Proceeding anyway.". This is addressed in this PR.

This Pull Request (PR) fixes the following issues

Fixes #289

dhoppe commented 5 years ago

@vanElden Thank you very much for your contribution, but you should not use a selector inside the file resource. Please implement a new parameter like service_file_mode at manifests/params.pp. You could also use this chance to fix then indentation to improve the readability.