search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Adding ulimit option to setenv.sh environment file #303

Closed rfreiberger closed 5 years ago

rfreiberger commented 5 years ago

Pull Request (PR) description

As defined in the Atlassian knowledge base article, Jira can run out of open file resources leading stability issues. The fix is to add the following line for the setenv.sh file. 

ulimit -n 16384

The current setenv.sh file does not allow this option and since others may run into this problem, wanted to add this feature into the module.

This Pull Request (PR) fixes the following issues

Adding the variable ulimit to allow defining ulimit settings in the setenv.sh file from the profile.

bastelfreak commented 5 years ago

@rfreiberger can you please have a look at the failing travis jobs?

rfreiberger commented 5 years ago

I'm going to close this pull request, after checking the values on my test instance the settings as defined by Atlassian do not increase the values on their own. You need to apply the changes to the systemd limits as well. This was noted by Tommy in the Puppet Slack community channel. I'm not sure if it's valued to add this systemd step to the module since this may be a unique request but will be opening another pr with better testing in the near future. Thank you.