Closed decibelhertz closed 3 years ago
I think we should use ˋˋˋcamptocamp/systemdˋˋˋ. @bastelfreak Do you agree?
I know you're not asking me, but will point out that it would be consistent with the Vox Pupuli Confluence module to do that... https://forge.puppet.com/puppet/confluence/dependencies
Sounds good. It looks like the Confluence module is a little bit smarter, because it does not restart by default.
Are you able to provide a pull request? That would be great.
I'm willing to do a PR (are several PRs?).
Upon code review, there are some organizational issues that I think would help when doing so. My questions would be:
jira::params
, some jira
, some none. Since that problem touches the issue I am talking about, I'd be interested in cleaning that up. Any opposition to me doing that?confluence
module code for systemd uses a selector in a resource declaration, which is not best practice. Won't be reproducing that. That ok?Of less interest, but will point out that I am willing to address while I working:
jira::facts
class for sure does not catch modern Puppet Enterprise installs (looking for a fact that is no longer there), which is what I use. The non-Enterprise path is working to report facts, but since its defaulting to /usr/bin/env ruby
for ruby, there is risk of odd performance if Puppet and rvm are being used on the same OS. Do you want me to clean up?jira::facts
also uses a selector at https://github.com/voxpupuli/puppet-jira/blob/master/manifests/facts.pp#L23-L25 which is not best practice ... Do you want me to fix that too?I'm currently on a cleanup spree, so it's pretty likely I'll do something to fix this too until I run out of steam :P Let's see.
Affected Puppet, Ruby, OS and module versions/distributions
How to reproduce (e.g Puppet code you use)
Change
$javahome
What are you seeing
I believe https://github.com/voxpupuli/puppet-jira/blob/master/manifests/service.pp#L41 should be
notify
, notbefore
.What behaviour did you expect instead
Change in JAVA_HOME env var should restart the service, not just refresh systemd.
Output log
Ran
service jira status -l
and found that the service was still running the old version of Java 8.Any additional information you'd like to impart
Am converting from Oracle JDK to AdoptOpenJDK JRE and the JIRA service needed to be manually restarted. I think this can be avoided with a simple metaparameter change.