search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Allow defining additional Tomcat connectors #316

Closed antaflos closed 4 years ago

antaflos commented 4 years ago

Pull Request (PR) description

Add a new, optional class parameter jira::tomcat_additional_connectors whose value is a well-formed, complex hash as described by the new type aliases Jira::Tomcat_connectors and Jira::Tomcat_attributes. Each hash key represents a port number, and the key's value is a hash that describes the connector's attributes and their values.

Useful for defining additional HTTP ports through which to access Jira. A typical use case is when Jira and Confluence run behind a reverse proxy and application links between Jira and Confluence must be set up. Then it is often better to allow Jira and Confluence to communicate directly instead of through the reverse proxy, but this requires a Tomcat connector that is configured for direct access instead of reverse proxy access (proxyName, proxyPort, etc). Described here: https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html

Contains spec tests, documentation and examples.

antaflos commented 4 years ago

Two out of four acceptance tests are failing in Travis but this is unrelated to my changes.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @antaflos, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

antaflos commented 4 years ago

Trying to close and re-open to trigger Travis tests again.

antaflos commented 4 years ago

The tests are fine now.

antaflos commented 4 years ago

Some test suites are failing now because of lots of bizarre errors like this:

examples/jira_postgres_nginx_ssl_install.pp:35:manifest_whitespace_closing_bracket_before:ERROR:there should be no whitespace or a single newline before a closing bracket

This is definitely not caused by my changes. I assume rubocop became much more strict in the last weeks?

vox-pupuli-tasks[bot] commented 4 years ago

Dear @antaflos, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

antaflos commented 4 years ago

Closing and reopening to trigger Travis, maybe the test failures unrelated to this change are now fixed.

antaflos commented 4 years ago

The checks now pass so if the PR could be merged, that'd be great :)

bastelfreak commented 4 years ago

thanks for the work!