search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Adapting templates to state if 8.7.1 tarball #317

Closed timdeluxe closed 3 years ago

timdeluxe commented 4 years ago

Pull Request (PR) description

This adapts the templates for java-check, server.xml and setenv to the state of the 8.7.1 tarball, while keeping required modifications in place.

I thought about setting stuff depending on the installed java version, however not everyone installs java also via puppet and if ones does it, it must not necessarily be via the java puppet module. Maybe we need an additional parameter to the module stating the java version?

This Pull Request (PR) fixes the following issues

Fixes #300

timdeluxe commented 4 years ago

I see failing tests, but those are not related to my changes, but to a general issue: https://github.com/moby/moby/issues/38749 If you look at that issue, other puppet modules stopped the test on centos-7 completely or pinned it to a specific version. Maybe one of those solutions should be adapted to this module also?

vox-pupuli-tasks[bot] commented 4 years ago

Dear @timdeluxe, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

timdeluxe commented 3 years ago

I was too dumb updating my branch. I will close this and raise another PR. I am sorry.