Feature/templatize jvm extra args

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module

https://forge.puppet.com/puppet/jira

Apache License 2.0

62 stars 143 forks source link

Feature/templatize jvm extra args #324

Closed bt-lemery closed 3 years ago

bt-lemery commented 4 years ago

Templatizing the JVM_EXTRA_ARGS parameter in setenv.sh to be able to accommodate custom settings.

vox-pupuli-tasks[bot] commented 4 years ago

Dear @bt-lemery, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

oranenj commented 3 years ago

Hi,

Thanks for the interest!

There's already something merged to master that achieves this. At any rate, I've overhauled the templates quite drastically recently, so fixing the conflicts in this one is going to be a huge pain. Therefore, I'll just close this PR.