Closed wolfaba closed 3 years ago
It would be good if we had a test which fails before making this change.
It would be good if we had a test which fails before making this change.
@kenyon is this for me to make some fail-test or is it your internal note? Sorry, I'm not profi-puppet, so I have really no idea what to do :(
It would be good if we had a test which fails before making this change.
@kenyon is this for me to make some fail-test or is it your internal note? Sorry, I'm not profi-puppet, so I have really no idea what to do :(
@wolfaba this is a note for whoever might want to work on this 😉. To elaborate: if this is really a bug, the tests should have caught it by causing a failure. So if no such failing test exists, that test should be written. Then you can fix the bug and be sure you've fixed it and that it won't reappear without causing a test failure.
I am also affected by this bug. As a workaround I defined all the JAVA_OPTS in a single line
I just realized that this is just a change to the docs, not the actual code, so disregard my note about tests. Merging. Thanks.
this yaml code for jira::java_opts with incorrect apostrophe generates with the template
JAVA_OPTS="<%= scope.lookupvar('jira::java_opts') %> $JAVA_OPTS"
incorrect codewhich generates then error
In fact, without apostrophe, it still generates linebreak in
JAVA_OPTS
, and then jira does not start. I will create ticket for this issue.