search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

modulesync 4.0.0 #334

Closed bastelfreak closed 3 years ago

bastelfreak commented 3 years ago

modulesync 4.0.0

ekohl commented 3 years ago

Not sure why PostgreSQL doesn't start on Ubuntu 16.04. It may be due to PIDFIle. https://github.com/voxpupuli/puppet-jira/pull/326 also broke Ubuntu due to bashisms. The next failure on Ubuntu 18.04 is that it doesn't recognize openjdk 11. Looks like the default version doesn't support that but recent ones do.

For now I'm giving up on this and someone who actually uses the module needs to step in.

kenyon commented 3 years ago

Not sure why PostgreSQL doesn't start on Ubuntu 16.04. It may be due to PIDFIle. #326 also broke Ubuntu due to bashisms. The next failure on Ubuntu 18.04 is that it doesn't recognize openjdk 11. Looks like the default version doesn't support that but recent ones do.

For now I'm giving up on this and someone who actually uses the module needs to step in.

This is the only remaining issue preventing the tests from passing. PostgreSQL on Ubuntu 16.04 starts but systemd hangs at "activating":

root@ubuntu1604-64-1:~# systemctl status postgresql@9.5-main
● postgresql@9.5-main.service - PostgreSQL Cluster 9.5-main
   Loaded: loaded (/lib/systemd/system/postgresql@.service; disabled; vendor preset: enabled)
   Active: activating (start) since Sun 2021-02-14 07:56:53 UTC; 37s ago
  Process: 6281 ExecStart=/usr/bin/pg_ctlcluster --skip-systemctl-redirect %i start (code=exited, status=0/SUCCESS)
   CGroup: /docker/378b796a749da8c903ba5f6f2da85ecf2ebd218038129f71e9f39a1c084d1d9a/system.slice/system-postgresql.slice/postgresql@9.5-main.service
           ├─6286 /usr/lib/postgresql/9.5/bin/postgres -D /var/lib/postgresql/9.5/main -c config_file=/etc/postgresql/9.5/main/postgresql.conf
           ├─6288 postgres: 9.5/main: checkpointer process
           ├─6289 postgres: 9.5/main: writer process
           ├─6290 postgres: 9.5/main: wal writer process
           ├─6291 postgres: 9.5/main: autovacuum launcher process
           └─6292 postgres: 9.5/main: stats collector process

Feb 14 07:56:53 ubuntu1604-64-1 systemd[1]: Starting PostgreSQL Cluster 9.5-main...
Feb 14 07:56:55 ubuntu1604-64-1 systemd[1]: postgresql@9.5-main.service: New main PID 6286 does not belong to service, and PID file is not owned by root. Refusing.
Feb 14 07:56:55 ubuntu1604-64-1 systemd[1]: postgresql@9.5-main.service: New main PID 6286 does not belong to service, and PID file is not owned by root. Refusing.

root@ubuntu1604-64-1:~# ll /run/postgresql/9.5-main.pid
-rw-r--r-- 1 postgres postgres 5 Feb 14 07:56 /run/postgresql/9.5-main.pid

root@ubuntu1604-64-1:~# cat /run/postgresql/9.5-main.pid
6286

:shrug:

Seems to be related to these:

Same problem here: https://github.com/voxpupuli/puppet-puppetboard/pull/292

ekohl commented 3 years ago

We have a pidfile workaround in our templates which uses an older version of Ubuntu 16.04 but I'd prefer to drop Ubuntu 16.04. It's going EOL soon anyway.

ekohl commented 3 years ago

This is green, but care should be taken. https://github.com/voxpupuli/puppet-jira/pull/345 is included and I've included an alternative to https://github.com/voxpupuli/puppet-jira/pull/341 as well.

ekohl commented 3 years ago

@kenyon thoughts?

kenyon commented 3 years ago

Looks good to me. Rebased on current master. Updated the Jira version in the alternative commit to #341.