search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

facts.pp: use localhost instead of 127.0.0.1 #338

Closed kenyon closed 3 years ago

kenyon commented 3 years ago

Use localhost instead of 127.0.0.1 so that we don't discriminate against IPv6-only configurations.

kenyon commented 3 years ago

Needs #340 for the tests to pass.

kenyon commented 3 years ago

I split this PR into separate PRs so that we produce a better changelog.

ekohl commented 3 years ago

I opened https://github.com/voxpupuli/puppet-jira/pull/347. Can we merge that first and then rebase this on top of it?

ekohl commented 3 years ago

I opened https://github.com/voxpupuli/puppet-jira/pull/349 to fix the tests