search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Updating check-java.sh and server.xml templates to upstream version #348

Closed timdeluxe closed 3 years ago

timdeluxe commented 3 years ago

Pull Request (PR) description

Updates check-java.sh and server.xml templates to upstream version. Especially the check-java update is required, when using a java version > 8 (or 1.8, depending which versioning scheme you look at.

This Pull Request (PR) fixes the following issues

Fixes #339 Kind of fixes #300

This replaces PR #317.

ekohl commented 3 years ago

The tests are failing. Could you have a look?

timdeluxe commented 3 years ago

Will do (probably on weekend), didn't find the time yet, sorry. Will revert the removal of < 8 support - as you said, it should be another PR, that should make the tests be green again.

timdeluxe commented 3 years ago

@ekohl PR is now updated

kenyon commented 3 years ago

Can you clean up the commit history (get rid of merge commit, combine fixup commits)? Or set the PR to allow edits by maintainers so we can do it.

kenyon commented 3 years ago

Also note that your kps email address is not registered with your GitHub account.

timdeluxe commented 3 years ago

@kenyon Thanks for the hints. Hope i won my fight against git rebase successfully now... (i am always fighting with it)

timdeluxe commented 3 years ago

@kenyon @ekohl Can i get a merge please?