Closed timdeluxe closed 3 years ago
The tests are failing. Could you have a look?
Will do (probably on weekend), didn't find the time yet, sorry. Will revert the removal of < 8 support - as you said, it should be another PR, that should make the tests be green again.
@ekohl PR is now updated
Can you clean up the commit history (get rid of merge commit, combine fixup commits)? Or set the PR to allow edits by maintainers so we can do it.
Also note that your kps email address is not registered with your GitHub account.
@kenyon Thanks for the hints. Hope i won my fight against git rebase successfully now... (i am always fighting with it)
@kenyon @ekohl Can i get a merge please?
Pull Request (PR) description
Updates check-java.sh and server.xml templates to upstream version. Especially the check-java update is required, when using a java version > 8 (or 1.8, depending which versioning scheme you look at.
This Pull Request (PR) fixes the following issues
Fixes #339 Kind of fixes #300
This replaces PR #317.