Refactor database configuration and make the main API typed

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module

https://forge.puppet.com/puppet/jira

Apache License 2.0

62 stars 143 forks source link

Closed oranenj closed 3 years ago

oranenj commented 3 years ago

Refactors DB configuration to use a single template.

Changes PostgreSQL defaults a bit, but I'm pretty sure the default was ineffective anyway, so this is half of an API break...

oranenj commented 3 years ago

Squashed and reworded a bit

oranenj commented 3 years ago

Needs another review, the changes are a bit more drastic now.

Basically, set defaults for ~everything to undef and omit them from dbconfig.xml unless specified by the user.

Also removes pool-size, I don't think it does anything, since it's not documented by Atlassian.

oranenj commented 3 years ago

I've also tested this on the Jira instance I have available and it doesn't break anything obvious, so I'll squash-merge.