search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 143 forks source link

Sync setenv.sh with upstream 8.13.5 (LTS) #357

Closed oranenj closed 3 years ago

oranenj commented 3 years ago

This undeprecates $java_opts for backwards compatibility and repurposes the other parameters to do what a custom $jvm_type did previously.

It removes "-XX:HeapDumpOnOutOfMemoryError" because that's not a default setting in the upstream setenv.sh

It also makes setting $jvm_permgen a no-op, since JIRA doesn't support JDK older than 8 anymore and the option does nothing

oranenj commented 3 years ago

So I decided to remove the heapdump setting because it's not on by default and theoretically could leak some data from memory to disk. I'm not sure why the module enabled it by default previously.

oranenj commented 3 years ago

Though on second thought, I think less disruptive would be to just add a new parameter that's preferred over jira::java_opts if defined, and leave the old default in place... On the other hand, if Atlassian decides to change setenv.sh again, the "main" API needs to change again to stay consistent...

oranenj commented 3 years ago

The merge conflict was with a redundant test