Remove jira::facts and rewrite upgrade logic

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module

https://forge.puppet.com/puppet/jira

Apache License 2.0

62 stars 143 forks source link

Remove jira::facts and rewrite upgrade logic #372

Closed oranenj closed 3 years ago

oranenj commented 3 years ago

There should be no need to depend on facts for upgrade.

We can bring the facts thing back if people really want it, but maybe after 5.0...

oranenj commented 3 years ago

For now, I added an acceptance test that tries to test an upgrade scenario. I guess we might merge that into the "defaults" test so that there's less duplication.

oranenj commented 3 years ago

woop, it's green. I'll rebase and restore the other OSes, and let's see...

oranenj commented 3 years ago

Rebased to squish a bugfix on Ubuntu 18 (systemctl path). I also changed managehome to false for the jira user; that makes more sense, since we create the directory anyway and it will contain jira data.