search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
61 stars 143 forks source link

Configure recommended JDBC connection-properties by default for PostgreSQL databases #381

Closed oranenj closed 3 years ago

oranenj commented 3 years ago

For PostgreSQL only. Also fixes #380

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

oranenj commented 3 years ago

Reference: https://confluence.atlassian.com/jirakb/connection-problems-to-postgresql-result-in-stuck-threads-in-jira-1047534091.html

Installing the upgraded driver via the module would also be useful, but out of scope for this PR.

oranenj commented 3 years ago

For most installations not configuring the values does not matter, but JIRA will complain about it on upgrades so let's do it.

oranenj commented 3 years ago

What's up with Ubuntu failing? I did nothing that would affect those tests...

oranenj commented 3 years ago

I'd like to merge this even though Ubuntu is failing. It seems there's just something in the mysql module that's not quite idempotent and the actual installation works fine.

oranenj commented 3 years ago

Bah, attempting to fix the tests just makes things worse.

oranenj commented 3 years ago

Since the only changes after approval were to make the MySQL tests run properly, I'll just merge this