search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Allow custom plugin installation and usage of JNDI database connections #389

Closed ThomasMinor closed 2 years ago

ThomasMinor commented 3 years ago

Pull Request (PR) description

Added feature to install custom plugins and use JNDI database connections

This Pull Request (PR) fixes the following issues

n/a

ThomasMinor commented 2 years ago

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

kenyon commented 2 years ago

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

Docs on running tests can be found here: https://github.com/voxpupuli/puppet-jira/blob/master/.github/CONTRIBUTING.md

root-expert commented 2 years ago

Hey @ThomasMinor took a look at the output of the tests. Sadly we have seen this error before. The current workaround is to add these 2 lines in our pipeline.

ThomasMinor commented 2 years ago

Hi @root-expert, I followed your advice to add the workaround and the tests succeeded - Thanks! I just have a few questions now...

root-expert commented 2 years ago
  • How did You identified the LANG settings as the cause of the problem from the logged messages?

The error was Error: /Stage[main]/Postgresql::Server::Reload/Exec[postgresql_reload]: invalid byte sequence in US-ASCII

bastelfreak had deployed that workaround in the past for puppet-zabbix so it was known to me :smile:

  • Isn't isn't it a bad idea to modify the ci.yml file due to the modulesync management?

Yes it will be overwritten, we manually add it back when we are modulesyncing. There's some discussion here regarding the issue btw.

root-expert commented 2 years ago

Can you squash you commits before merging?