Avoid duplicate scheme declaration when using proxy with SSL

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module

https://forge.puppet.com/puppet/jira

Apache License 2.0

61 stars 143 forks source link

Avoid duplicate scheme declaration when using proxy with SSL #396

Closed jmcnatt closed 2 years ago

jmcnatt commented 2 years ago

Pull Request (PR) description

Added negation logic when scheme key is present when iterating through the proxy hash.
Added additional test for tomcat_native_ssl without proxy settings.

This Pull Request (PR) fixes the following issues

Fixes #395

root-expert commented 2 years ago

I think the actual fix for this to add a ! in the condition here.

In fact, that was the case before the template was converted to epp and by accident ! was removed.

References, here and here

Can you also rebase with master branch to fix conflicts and the failing specs? Adding some specs for this so it won't break in the future would be awesome!

jmcnatt commented 2 years ago

Makes sense! I'll rebase, update the PR, and see if I can author a spec for this condition.

jmcnatt commented 2 years ago

Updated the PR to use the ! logic instead of unless.

I was able to write a spec context for specifying tomcat_native_ssl: true with and without proxy. Looking for duplicate scheme="https" may be difficult without checking for exact contents of the entire file (at least when using with_content()).

jmcnatt commented 2 years ago

I rebased and removed the spacing and quotation change.