search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
61 stars 143 forks source link

Add Puppet 8 support #408

Closed bastelfreak closed 5 months ago

danifr commented 8 months ago

Hi @bastelfreak, since I am preparing the 5.2.0 release, does it make sense to merge some of the opened PR? We have some that are quite safe to merge

danifr commented 8 months ago
bastelfreak commented 8 months ago

None of the linked PRs have passing CI. This needs to be fixed before we continue. I currently don't have tue capacity to work on them. If you want, you can. pick those up, fix CI and resubmit them as new PRs.

danifr commented 8 months ago

I see. I don't mind doing the work, but my knowledge about this is close to zero (and most of the CI logs have expired and are no longer available.)

If there is something easy I can start with please let me know.

About modulesync, actually for release I am preparing I rebased from your https://github.com/voxpupuli/puppet-jira/pull/394 because I couldn't wrap my head around the instructions in https://voxpupuli.org/docs/releasing_version/

The docs say "Run modulesync to ensure the dotfiles are up-to-date." but it does not explain how.

Thanks

h-haaks commented 5 months ago

@bastelfreak with #414 this i obsolete. Is it ok to just close and delete the branch?

bastelfreak commented 5 months ago

This isn't obsolete. The metadata.json currently doesn't list Puppet 8.