search

voxpupuli / puppet-jira

Atlassian JIRA Puppet Module
https://forge.puppet.com/puppet/jira
Apache License 2.0
62 stars 144 forks source link

Bugfix java 17 support per atlassian upstream #413

Closed valentino-aguiar-gsa closed 7 months ago

valentino-aguiar-gsa commented 8 months ago

See https://jira.atlassian.com/browse/JRASERVER-76224 for details on this. This snippet was taken directly from the setenv.sh script from JIRA 9.11.1.

Pull Request (PR) description

This PR updates setenv.sh with the fix from atlassian's upstream setenv.sh script. It simply checks if java 17 is in use, and if so, then it includes the JVM_OPENS parameters.

This Pull Request (PR) fixes the following issues

Fixes #412

valentino-aguiar-gsa commented 8 months ago

The failing check failing appears to be unrelated (init.pp hasn't been modified by this pr).

h-haaks commented 7 months ago

@valentino-aguiar-gsa could you please rebase your branch?

valentino-aguiar-gsa commented 7 months ago

Hi, rebased. Didn't notice, thanks!

valentino-aguiar-gsa commented 7 months ago

Will adjust to only include the 1 commit shortly

bastelfreak commented 7 months ago

@valentino-aguiar-gsa can you please rebase against our master branch to get rid of the merge commit?

valentino-aguiar-gsa commented 7 months ago

Sorry about that, all sorted. Note to self, dont use the 'sync' option in github web ui.