voxpupuli / puppet-k8s

Home for the K8s Puppet module
Apache License 2.0
9 stars 12 forks source link

do more precisely naming #59

Closed rwaffen closed 1 year ago

rwaffen commented 1 year ago

just renaming of a var. so it is more precise and does not use discriminatory language anymore.

rwaffen commented 1 year ago

so besides the renaming and changing of the module api, the change of the deprecated node-role is also ab breaking fact? I just googled it and found the old name is deprecated. but what problem will people with older clusters face then? can we somehow write a update path?

rwaffen commented 1 year ago

for reference:

i tested it on an old cluster, nothing happened, except a redeployment of coredns. but when i check, i dont see that such a taint/label is ever applied to the servers. not from this module.